Quota check preceding resource check #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… create a single resource name group
…orrowing at the root
…dispatch AppWrappers that would have enough quota if borrowing AppWrappers are discounted from the resources (due to those being preempted).
|
I recommend looking at the changes in |
asm582
reviewed
Aug 28, 2023
asm582
reviewed
Aug 28, 2023
asm582
reviewed
Aug 28, 2023
pkg/controller/quota/quotaforestmanager/qm_lib_backend_with_quotasubt_mgr.go
Show resolved
Hide resolved
asm582
reviewed
Aug 28, 2023
pkg/controller/quota/quotaforestmanager/qm_lib_backend_with_quotasubt_mgr.go
Show resolved
Hide resolved
asm582
reviewed
Aug 28, 2023
asm582
reviewed
Aug 29, 2023
pkg/controller/quota/quotaforestmanager/qm_lib_backend_with_quotasubt_mgr.go
Show resolved
Hide resolved
asm582
approved these changes
Aug 29, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asm582 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
#467
What changes have been made
MCAD with quota management allows AppWrappers to borrow quota from other nodes to maximize cluster utilization. In such cases, the borrowing AppWrappers can be preempted by new AppWrappers that request quota within their allocation (because the borrowing AppWrappers should not have full control of quota that is not theirs). This means that when counting the resources available in the cluster to consider if an AppWrapper can be dispatched, the utilized resources of AppWrappers that could be preempted due to borrowing should be considered available for the dispatch check. This PR swaps the resource check and the quota check so that quota is checked first and it updates the resources available in case some AppWrappers can be preempted. If the quota passes but the resources are not enough (even after preemption), the state of the quota tree is recovered and the AppWrapper is put back in the queue for later retry.
Verification steps
Manual testing was performed with 2 AppWrappers: The first one fills up the cluster even though its quota is just a portion of the cluster. The second one requests quota withing its allocation, and despite the fact that the cluster is full, it is dispatched and the first AppWrapper is preempted.
Checks